7:30 a.m.
Deleting external snapshots will require configuring autofinalize to
synchronize the block jobs for disks withing single snapshot in order to
be able safely abort of one of the jobs fails.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_block.c | 3 ++-
src/qemu/qemu_monitor.c | 9 +++++----
src/qemu/qemu_monitor.h | 3 ++-
src/qemu/qemu_monitor_json.c | 4 ++--
src/qemu/qemu_monitor_json.h | 3 ++-
tests/qemumonitorjsontest.c | 2 +-
6 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 8a633d4423..5600abf6aa 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3348,7 +3348,8 @@ qemuBlockCommit(virDomainObj *vm,
job->name,
topSource->nodeformat,
baseSource->nodeformat,
- backingPath, bandwidth);
+ backingPath, bandwidth,
+ VIR_TRISTATE_BOOL_YES);
qemuDomainObjExitMonitor(vm);
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 0354832fa5..43525def0c 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -2795,16 +2795,17 @@ qemuMonitorBlockCommit(qemuMonitor *mon,
const char *topNode,
const char *baseNode,
const char *backingName,
- unsigned long long bandwidth)
+ unsigned long long bandwidth,
+ virTristateBool autofinalize)
{
- VIR_DEBUG("device=%s, jobname=%s, topNode=%s, baseNode=%s, backingName=%s,
bandwidth=%llu",
+ VIR_DEBUG("device=%s, jobname=%s, topNode=%s, baseNode=%s, backingName=%s,
bandwidth=%llu, autofinalize=%d",
device, NULLSTR(jobname), NULLSTR(topNode),
- NULLSTR(baseNode), NULLSTR(backingName), bandwidth);
+ NULLSTR(baseNode), NULLSTR(backingName), bandwidth, autofinalize);
QEMU_CHECK_MONITOR(mon);
return qemuMonitorJSONBlockCommit(mon, device, jobname, topNode, baseNode,
- backingName, bandwidth);
+ backingName, bandwidth, autofinalize);
}
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index eebac918c1..d09439911f 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -973,7 +973,8 @@ int qemuMonitorBlockCommit(qemuMonitor *mon,
const char *topNode,
const char *baseNode,
const char *backingName,
- unsigned long long bandwidth)
+ unsigned long long bandwidth,
+ virTristateBool autofinalize)
ATTRIBUTE_NONNULL(2);
int qemuMonitorArbitraryCommand(qemuMonitor *mon,
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index baf01a7206..9aee84084e 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -4028,11 +4028,11 @@ qemuMonitorJSONBlockCommit(qemuMonitor *mon,
const char *topNode,
const char *baseNode,
const char *backingName,
- unsigned long long speed)
+ unsigned long long speed,
+ virTristateBool autofinalize)
{
g_autoptr(virJSONValue) cmd = NULL;
g_autoptr(virJSONValue) reply = NULL;
- virTristateBool autofinalize = VIR_TRISTATE_BOOL_YES;
virTristateBool autodismiss = VIR_TRISTATE_BOOL_NO;
cmd = qemuMonitorJSONMakeCommand("block-commit",
diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h
index 073a0579b5..a03caf7740 100644
--- a/src/qemu/qemu_monitor_json.h
+++ b/src/qemu/qemu_monitor_json.h
@@ -315,7 +315,8 @@ qemuMonitorJSONBlockCommit(qemuMonitor *mon,
const char *topNode,
const char *baseNode,
const char *backingName,
- unsigned long long bandwidth)
+ unsigned long long bandwidth,
+ virTristateBool autofinalize)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
int
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index f224ccb364..1db1f2b949 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -1211,7 +1211,7 @@ GEN_TEST_FUNC(qemuMonitorJSONRemoveNetdev, "net0")
GEN_TEST_FUNC(qemuMonitorJSONDelDevice, "ide0")
GEN_TEST_FUNC(qemuMonitorJSONBlockdevMirror, "jobname", true, "vdb",
"targetnode", 1024, 1234, 31234, true, true)
GEN_TEST_FUNC(qemuMonitorJSONBlockStream, "vdb", "jobname",
"backingnode", "backingfilename", 1024)
-GEN_TEST_FUNC(qemuMonitorJSONBlockCommit, "vdb", "jobname",
"topnode", "basenode", "backingfilename", 1024)
+GEN_TEST_FUNC(qemuMonitorJSONBlockCommit, "vdb", "jobname",
"topnode", "basenode", "backingfilename", 1024,
VIR_TRISTATE_BOOL_YES)
GEN_TEST_FUNC(qemuMonitorJSONScreendump, "devicename", 1, NULL,
"/foo/bar")
GEN_TEST_FUNC(qemuMonitorJSONOpenGraphics, "spice", "spicefd",
false)
GEN_TEST_FUNC(qemuMonitorJSONNBDServerAdd, "vda", "export", true,
"bitmap")
--
2.38.1