Re: [libvirt] [PATCH] storage pool discovery

On Wed, 2008-08-27 at 17:51 +0100, Daniel P. Berrange wrote: > On Mon, Aug 25, 2008 at 10:33:45AM -0400, David Lively wrote: > > After making the change I suggested above, it now feels a little strange > > because "Pool" is gone from the name. I'm starting to think > > "*Discover[Storage]PoolSources*" is the only good choice. It's rather > > long, but makes it clear we're talking about storage pool sources (as > > opposed to "storage sources", which feels a little ambiguous, or > > "storage pools" which isn't accurate since they're not (yet) pools). > > Discover is a bit of a long word - lets use 'Find' instead, so it makes > the API name a little shorter - and no worse than our existing longest > API name. In other words: > > virConnectFindStoragePoolSources() Sounds good. The attached patch uses this name (and others consistent with it), and should implement all the suggestions from Daniel V and Jim M.