Re: [PATCH 00/10] To make <transient/> disk sharable for qemu
On Wed, Mar 24, 2021 at 20:54:04 -0400, Masayoshi Mizuma wrote:
This patch series has two parts; the first part is trying to support
for hotplugging disks with <transient/> option for qemu, and make the
disk shareable when <shareable/> disk option is set as well.
The second part is trying to make shareable the disks with <transient/>
disk option which is described on the domain xml. The second part
is marked as Work In Progress (WIP) because the design may be modified
by the first part changes.
I have had a look at this series and I have spotted a few significant
problems with it:
- <shareable/> must not be abused in this case, since you've used it in
a different meaning that it actually has:
- shareable means that the TOP image is shareable between VMs
- QCOW2 images must not be shareable as QCOW2 metadata can't be
shared
- the combination of commandline instantiated -blockdev backends and
hotplugged disk frontends
- everything should be done together
- tests fail in between patches
Since I'm planning a few refactors around this code which will allow
simpler fixing of some of the problems I have with the patches I think
it will be best if I pick up the patches and fix them after I'm done
with the refactors, so there's no need to attempt to fix the problems
I've pointed out for now.
Thanks
Peter