Re: [libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()

On Thu, Jan 14, 2016 at 9:38 PM, Chris Lalancette <clalancette@gmail. com> wrote: > > Hi! > > On Thu, Jan 14, 2016 at 2:56 PM, Dan Williams <dcbw(a)redhat.com&gt; > wrote: > > > > > On Thu, 2016-01-14 at 13:19 -0500, Laine Stump wrote: > > > > > > On 01/14/2016 11:01 AM, Dan Williams wrote: > > > > > > > > On Thu, 2016-01-07 at 11:12 -0600, Dan Williams wrote: > > > > > > > > > > Not all lease values are mandatory, and when they aren't > > > > > supplied > > > > > by the libvirt driver they get set to NULL.  That makes > > > > > rb_str_new2() bail out. > > > > Ping?  Does this patch look OK or is there anything else I > > > > need to > > > > do > > > > with it?  Is the submission procure for ruby-libvirt > > > > different than > > > > normal libvirt? > > > As far as I can see, posting to libvir-list is the correct > > > thing for > > > ruby-libvirt patches, I think it's just that very few people > > > use it, > > > so > > > most of us don't feel comfortable ACKing anything for it. > > Thanks!  I'd bet a lot more people use it than you think, since > > it's a > > dependency of vagrant-libvirt by way of fog.  So you can't stand > > up a > > vagrant machine using libvirt without it... > > > > > Dan > > > > > > > > > > It looks like Chris Lalancette is the maintainer and has been > > > the > > > author > > > of nearly every patch in the last couple years, so I'm Cc'ing > > > him to > > > be > > > sure it see it > > For whatever reason, I didn't see your earlier patches.  I'll take > a look > and get back to you. > I've now applied the patch.  Thanks for the contribution!