Re: [libvirt] [PATCH] Add generic parameter=value support for virsh's schedinfo command
On Tue, Oct 07, 2008 at 01:55:28PM -0700, Dan Smith wrote:
This patch maintains the two Xen-specific --weight and --cap
options,
but adds support for setting arbitrary parameters by specifying them in
param=value syntax.
Changes to the virsh manual are included.
Sounds good, but ...
+ if (sscanf(set, "%a[^=]=%i", ¶m_name,
¶m_value) != 2) {
a is not part of C89, that's an extension to the standard if i believe
the linux man page. I would rather avoid a portability problem here
Otherwise looks fine to me,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/