Re: [libvirt] [PATCH] Don't copy sexpr node value that is an empty string

18 Nov 2011


      On 11/18/2011 03:16 PM, Jim Fehlig wrote:
...
Xen4.1 initializes some unspecified sexpr config items to an empty
string, unlike previous Xen versions that would leave the item unset.
E.g. the kernel item for an HVM guest (non-direct kernel boot):
Xen4.0 and earlier
  ...
  (image
    (hvm
      (kernel )
  ...
Xen4.1
  ...
  (image
    (hvm
      (kernel '')
  ...
Thanks for the examples; that helps understand the patch.
...
-    if (val) {
+    if (val && *val) {
         *dst = strdup(val);
ACK.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org