Re: [libvirt] [PATCH] Make sure struct sockaddr_in is defined on FreeBSD
On 11/13/2010 08:52 AM, Matthias Bolte wrote:
---
src/util/network.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/util/network.h b/src/util/network.h
index 0900e29..724a5f8 100644
--- a/src/util/network.h
+++ b/src/util/network.h
@@ -21,6 +21,10 @@
# include <netdb.h>
# include <stdbool.h>
+# ifdef __FreeBSD__
+# include <netinet/in.h>
+# endif
+
NACK as written. POSIX states that <netdb.h> may, but not must, define
sockaddr_in.
Therefore, the correct fix is to unconditionally include <netinet/in.h>,
which is the only header guaranteed by POSIX to declare that struct.
(That is, turn your four-line addition into a two-line addition - it
doesn't hurt to make the include unconditional). ACK with that change.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)