On Wed, Oct 10, 2018 at 10:14:44 +0100, Daniel Berrange wrote:
On Wed, Oct 10, 2018 at 11:06:38AM +0200, Michal Privoznik wrote:
On 10/10/2018 10:45 AM, Daniel P. Berrangé wrote:
[...]
I view code under src/conf/ to be hypervisor agnostic (at least it should be) and thus any hypervisor specific decisions/changes to user XML should be made from src/hypervisor/.
So we should move the hack to the post-parse callbacks in the xen driver - but we don't have an equivalent pre-format callback for the reverse hack, do we ?
No we don't. Any hacks necessary are built into the formatter so that they operate on temporary copies of the data. Having anything that would modify the def on formatting would seem like a bad idea since that can happen at random points. Doing a copy of the def to do that would be expensive and also in current situation pointless since copy is done via format->parse, so a post-parse gets applied anyways there.