Re: [libvirt] [PATCH 06/10] Fix allocation of arglist in qemuStringToArgvEnv

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; In commit 41b550567918790cb304378f39c3ba369bcca28e Author: Eric Blake <eblake(a)redhat.com&gt; Date: Wed Aug 28 15:01:23 2013 -0600 qemu: simplify list cleanup The qemuStringToArgvEnv method was changed to use virStringFreeList to free the 'arglist' array. This method assumes the string list array is NULL terminated, however, qemuStringToArgvEnv was not ensuring this when populating 'arglist'. This caused an out of bounds access by virStringFreeList when OOM occured in the initial loop of qemuStringToArgvEnv Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/qemu/qemu_command.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)