Re: [libvirt] [PATCH] vepa: parsing for 802.1Qb{g|h} XML
On Mon, May 10, 2010 at 07:57:37PM -0400, Stefan Berger wrote:
Below is David Alan's original patch with lots of changes.
In particular, it now parses the following XML and stored the data
internally. No sending of netlink messages has been implemented here.
<interface type='direct'>
<source dev='static' mode='vepa'/>
<model type='virtio'/>
<vsi managerid='12' typeid='0x123456' typeidversion='1'
instanceid='fa9b7fff-b0a0-4893-8e0e-beef4ff18f8f' />
<filterref filter='clean-traffic'/>
</interface>
<interface type='direct'>
<source dev='static' mode='vepa'/>
<model type='virtio'/>
<vsi profileid='my_profile'/>
</interface>
I'd suggest to use this patch as a base for sending out netlink
messages.
Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>
I have 2 basic questions:
- how can we be sure that if we apply this the XML interface won't
need to change due to kernel interfaces, maybe Chris can confirm
that the kernel is now stable enough that this should not affect
the XML anymore
- can I get some signoff from Cisco that there is agreement on this
format and that will be sufficient for their need
If I get the 2 ACK then I will review and push, assuming the low level
activation via netlink can be finalized in another patch. But if there
is still too many doubts about the low level, then I prefer to wait a
bit since by definition the patch is not functional as-is but rather
an attempt at stabilizing the libvirt API level,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/