Re: [libvirt] [PATCH] qemudDomainSetVcpus: avoid NULL-deref

15 May 2010


      Eric Blake wrote:
...
On 05/14/2010 04:42 AM, Jim Meyering wrote:
...
Here's a patch for a coverity-spotted bug:
...
From 12160fa54bc948e5de3fecff6a9552995e9595b0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 14 May 2010 12:38:43 +0200
Subject: [PATCH] qemudDomainSetVcpus: avoid NULL-deref
* src/qemu/qemu_driver.c (qemudDomainSetVcpus): Avoid NULL-deref
upon unknown UUID.  Call qemuDomainObjBeginJob(vm) only after
ensuring that vm != NULL, not before.  This potential NULL-deref
was introduced by commit 2c555d87b0041e0d1ec4742386d2161d1b2f0600.
ACK.
Thanks.  Pushed.