On Tue, Aug 08, 2006 at 04:15:40PM +0100, Daniel P. Berrange wrote:
On Tue, Aug 08, 2006 at 10:31:38AM -0400, Daniel Veillard wrote:
looks perfect, I would just nitpick about the use of atoi which doesn't catch errors (strtol is better I guess). And also the fact that the patch to format.html should really be applied to libvir.html because all htmls are generated from it via the stylesheets (make rebuild in doc directory).
Attached an updated patch using strol (i had copied the use of atoi from other methods in that xs_internal.h file though ;-). Also made the changes
I told you I was nitpicking :-)
to libvir.html instead.
Looks all fine to me ! Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/