On Tue, Jul 29, 2008 at 08:53:27AM +0100, Daniel P. Berrange wrote:
On Mon, Jul 28, 2008 at 10:12:49AM -0400, Daniel Veillard wrote:
On Mon, Jul 28, 2008 at 05:38:47PM +0400, Evgeniy Sokolov wrote:
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: In general that looks way cleaner to me, I will give it a few nmore days and apply, unless you suggest another version,
fixed patch is attached.
Okay, I applied and commited this because it enforces the transition to the new XML format for OpenVZ and any such change should be done as soon as possible. But Dan's point remain, we need to transition to the new reading routines, and virDomainNetDefParseXML will have to be made static again when done. But as I understand you agree with this so it's just an intermediate state of the code :-)
This patch doesn't work or compile because it is missing an argument to virXPathNodeSet(). Please make sure you're developing against the latest CVS checkout of libvirt when submitting patches, and run the configure script with the '--enable-compile-warnings=error' argument the catch this sort of problem before submission.
Humpf ... the problem is that I ran autogen between testing both versions of the patch and the --with-openvz vanished. Fixing in CVs, it's trivial, but also activating OpenVZ and LXC support by default, there is no good reason to not do so at this point. Sorry, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/