Re: [libvirt] [PATCH 1/5] tests: qemuxml2argvmock: Don't mock virCommandPassFD

On 08/14/2018 03:21 PM, Peter Krempa wrote: > This function does not modify the host. It merely puts the file > descriptor into a list in virCommandPtr. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > tests/qemuxml2argvmock.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c > index 4df92cf396..c8a5f186d5 100644 > --- a/tests/qemuxml2argvmock.c > +++ b/tests/qemuxml2argvmock.c > @@ -184,14 +184,6 @@ virNetDevRunEthernetScript(const char *ifname ATTRIBUTE_UNUSED, > return 0; > } > > -void > -virCommandPassFD(virCommandPtr cmd ATTRIBUTE_UNUSED, > - int fd ATTRIBUTE_UNUSED, > - unsigned int flags ATTRIBUTE_UNUSED) > -{ > - /* nada */ > -} > - > int > virNetDevOpenvswitchGetVhostuserIfname(const char *path ATTRIBUTE_UNUSED, > char **ifname) > NACK, this indeed causes caller to close wrong FD: libvirt.git/tests $ ../run valgrind --trace-children=yes ./qemuxml2argvtest ==210382== Warning: invalid file descriptor 1729 in syscall close()