On 12/02/2014 12:08 PM, Laine Stump wrote:
These two functions use netlink RTM_NEWNEIGH and RTM_DELNEIGH messages to add and delete entries from a bridge's fdb. The bridge itself is not referenced in the arguments to the functions, only the name of the device that is attached to the bridge (since a device can only be attached to one bridge at a time, and must be attached for this function to make sense, the kernel easily infers which bridge's fdb is being modified by looking at the device name/index). ---
Change from V1: turn the anonymous enum for flags into a typedefed enum so the name can be used in the function args, thus providing self-documentation. Also took John's suggestion of documenting the code directly with the information from the commit log message (and added the statement that adding an existing entry, or deleting a non-existing entry, is an error.)
src/libvirt_private.syms | 2 + src/util/virnetdevbridge.c | 147 +++++++++++++++++++++++++++++++++++++++++++++ src/util/virnetdevbridge.h | 16 +++++ 3 files changed, 165 insertions(+)
ACK John