Re: [PATCH ocaml 0/3] Small fixes for OCaml 4.10.
On Fri, Jan 24, 2020 at 03:01:51PM +0000, Daniel P. Berrangé wrote:
On Fri, Jan 24, 2020 at 02:51:39PM +0000, Richard W.M. Jones wrote:
> On Fri, Jan 24, 2020 at 02:35:01PM +0000, Daniel P. Berrangé wrote:
> > On Sun, Jan 19, 2020 at 01:04:07PM +0000, Richard W.M. Jones wrote:
> > > Basically OCaml 4.10 is much more strict about the difference between
> > > string (immutable) and bytes (mutable).
> >
> > For all patches
> >
> > Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
> >
> > I presume this will fix the rawhide CI failure we have with ocaml
> > now.
>
> Well the previous code didn't compile with OCaml 4.10 at all, so I
> guess so. However I wasn't previously aware we even had CI for this.
> Do you have a link?
Rawhide was succeeding until most recent build:
https://ci.centos.org/view/libvirt/job/libvirt-ocaml-build/
which I presume matches when the VM got updated to ocaml 4.10
While it passes 4.10 and Fedora 30/31 with ocaml 4.9, it fails
on CentOS 7 with 4.05 and Debian with 4.02
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|