Re: [libvirt] [jenkins-ci PATCH 02/22] guests, lcitool: Use install_url in the unattended install files
On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
guests,lcitool: Use install_url in the unattended install files
s/^guests,//
+++ b/guests/configs/kickstart.cfg
+# Set the installation url
+url --url={{ install_url }}
I know it doesn't make any difference in practice, but setting this
up right in between configuring the bootloader and the network is
a... rather peculiar choice.
Please move this to the very top of the file, and include a proper
comment for it like
# Installation source
#
# The operating system will be installed from the following URL
Everything else looks good, so with these nits fixed
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization