Re: [PATCH] network: refactor networkSetIPv6Sysctls() for proper g_autofree usage
On a Friday in 2020, Laine Stump wrote:
This function used the same char* three times for different purposes,
freeing it after each use. Since we don't want to ever manually free
an autofree'd pointer, modify it to use three separate char*, and make
them all g_autofree.
Signed-off-by: Laine Stump <laine(a)redhat.com>
---
This was suggested by Jan in
https://www.redhat.com/archives/libvir-list/2020-July/msg00805.html
Oops, I should have been more verboser.
Just a note for the mailing list that this was resolved by my:
commit 5c50d1dda5664d480e6370111c0218947706bd31
network: split out networkSetIPv6Sysctl
which removed the repetitive use by moving it to a separate function.
Jano
pushing this patch along with the patch 5 referenced there will
permit
pushing patch 06/15 of that series unmodified.
src/network/bridge_driver.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)