On Mon, Jul 19, 2021 at 02:07:10PM +0200, Olaf Hering wrote:
Am Mon, 19 Jul 2021 09:55:37 +0100 schrieb Daniel P. Berrangé <berrange@redhat.com>:
I don't see that would have made any change since --listen was not enabled either before / after the changes.
It was the default in the SUSE package. I should have checked libvirt.git if it has been used.
Originally the sysconfig file provided a way to override the initscripts config, and was kept with systemd units essentially because it already exists. Now that initscripts are completely gone, the sysconfig possibly doesn't need to exist, as it is already posible to override unit files in a reasonably simple manner.
I have seen sysv scripts that do "test -f sysconfig/file && . $_", so in some sense sysconfig was already optional before. I have not checked if the sysv scripts from libvirt.git had such code.
So, do you or anyone else agree to get rid of sysconfig files in libvirt.git and put the defaults provided by libvirt.git into the systemd unit files? Just as I proposed in my patch?
The challenge i see here is that of managing upgrades to the proposed state. By putting '--timeout=xxx' into the .service file, everyone is going get that change installed, even if they modified their .sysconfig file previously and thus don't currently have it. <hand waving> I think we would need some task that looks at the .sysconfig file that exists, and then drops in a /etc/systemd/system/libvirtd.service.d/notimeout.conf file to disable the --timeout usage, if it was not currently in use. </hand waving>
If yes, should it be one monolithic change that touches also libvirt.spec and the NEWS file?
Yes, if we do this it would need to be for everything I think. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|