Re: [libvirt] [PATCH 07/24] tests: utils: Add virTestLoadFilePath helper

On 07/26/2017 05:00 AM, Peter Krempa wrote: > This new helper loads and returns a file from 'abs_srcdir'. By using > variable arguments for the function, it's not necessary to format the > path separately in the test cases. > --- > tests/testutils.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/testutils.h | 2 ++ > 2 files changed, 53 insertions(+) > > + > +/** > + * virTestLoadFilePath: > + * @...: file name components. Mention that it must end in NULL... > + * > + * Constructs the test file path from variable arguments and loads the file. > + * 'abs_srcdir' is automatically prepended. > + */ > +char * > +virTestLoadFilePath(const char *p, ...) and gcc has an attribute to mark vararg functions that require a NULL sentinel, to let the compiler enforce correct usage.

--- a/tests/testutils.h +++ b/tests/testutils.h @@ -52,6 +52,8 @@ int virTestRun(const char *title, int (*body)(const void *data), const void *data); int virTestLoadFile(const char *file, char **buf); +char *virTestLoadFilePath(const char *p, ...) + ATTRIBUTE_SENTINEL;