Re: [libvirt] [PATCH v3 1/4] conf: introduce generic ISA address

On Mon, Dec 09, 2013 at 05:11:13PM +0800, Hu Tao wrote:

> --- > docs/formatdomain.html.in | 5 ++++ > docs/schemas/basictypes.rng | 17 ++++++++++++ > docs/schemas/domaincommon.rng | 6 +++++ > src/conf/domain_conf.c | 63 ++++++++++++++++++++++++++++++++++++++++++- > src/conf/domain_conf.h | 9 +++++++ > 5 files changed, 99 insertions(+), 1 deletion(-) ACK > @@ -3053,6 +3054,13 @@ virDomainDeviceInfoFormat(virBufferPtr buf, > case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: > break; > > + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA: > + if (info->addr.isa.iobase > 0) > + virBufferAsprintf(buf, " iobase='0x%x'", info->addr.isa.iobase); > + if (info->addr.isa.irq> 0) Minor whitespace bug.