On 12/12/2013 05:07 AM, Daniel P. Berrange wrote:
On Mon, Dec 09, 2013 at 05:11:13PM +0800, Hu Tao wrote:
Commit message should mention the new XML.
--- docs/formatdomain.html.in | 5 ++++ docs/schemas/basictypes.rng | 17 ++++++++++++ docs/schemas/domaincommon.rng | 6 +++++ src/conf/domain_conf.c | 63 ++++++++++++++++++++++++++++++++++++++++++- src/conf/domain_conf.h | 9 +++++++ 5 files changed, 99 insertions(+), 1 deletion(-)
ACK
@@ -3053,6 +3054,13 @@ virDomainDeviceInfoFormat(virBufferPtr buf, case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: break;
+ case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA: + if (info->addr.isa.iobase > 0) + virBufferAsprintf(buf, " iobase='0x%x'", info->addr.isa.iobase); + if (info->addr.isa.irq> 0)
Minor whitespace bug.
Fixed and will push when I get through the rest of the series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org