Re: [libvirt] RFC: <memory units=...> [was: libvirt doesn't boot kVM, hangs, qemu on 100% CPU]
Hey,
On Wed, Feb 22, 2012 at 04:42:59PM -0700, Eric Blake wrote:
There ain't no way on earth you're going to boot a kernel in
2 megabytes
of memory!
I propose enhancing the XML; on output, libvirt should produce:
<memory units='k'>2048</memory> => 2048 * kibibyte
the output unit must remain the same as it has always been, but the new
attribute will make it easier for humans reading the XML to spot
blunders like what spawned this thread.
[...]
Thoughts before I propose such a patch?
For what it's worth, there are other places with unitless sizes, there's at
least <video vram=...>, everything under <memtune> and <bandwidth> (not
something measured in bytes though), and these 3 <pool> children:
<allocation>, <capacity> and <available>.
(NB: looked at your patches now and saw you handle memtune)
Also, <volume><allocation> and <volume><capacity> already
support a "unit" attribute which accept the K, M, G, T, P, E values
(xxxbyte), for consistency it would be better for the new <memory> attribute
to use "unit" and not "units" as suggested by Mathias, and for both
"unit"
attributes to accept the same values.
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 198 bytes)