Re: [libvirt] [PATCH] qemu: remove ATTRIBUTE_UNUSED in connectGetType

On 05/13/2016 03:07 PM, Fabian Freyer wrote:

This is not needed here, since the conn parameter is used in the ACL checking calls, which were introduced in abf75aea2. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c4c4968..37d970e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1228,7 +1228,7 @@ qemuConnectSupportsFeature(virConnectPtr conn, int feature) } }

-static const char *qemuConnectGetType(virConnectPtr conn ATTRIBUTE_UNUSED) { +static const char *qemuConnectGetType(virConnectPtr conn) { if (virConnectGetTypeEnsureACL(conn) < 0) return NULL;

ACK and pushed Thanks, Cole