On Thu, Jan 09, 2020 at 09:16:34AM +0100, Pavel Hrdina wrote:
We use this module but we don't have explicit dependency on it.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- bootstrap.conf | 2 ++ 1 file changed, 2 insertions(+)
GNULIB says https://www.gnu.org/software/gnulib/manual/html_node/pthread_002eh.html Portability problems fixed by Gnulib: This header pollutes the namespace with some broken macro implementations for various functions such as strtok_r and gmtime_r: mingw 3.0. We currently build with mingw32-winpthreads-6.0.0, and AFAICT that doesn't have the described problem. So I don't think we actually need this pthread_h module from GNULIB at all.
diff --git a/bootstrap.conf b/bootstrap.conf index 13d0e77514..a302475198 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -84,6 +84,8 @@ gnulib_modules="$gnulib_modules pipe2" gnulib_modules="$gnulib_modules poll" # -> Meson gnulib_modules="$gnulib_modules posix-shell" +# -> GThread +gnulib_modules="$gnulib_modules pthread-h" # -> open code conditional logic gnulib_modules="$gnulib_modules pthread_sigmask" # -> GSocket -- 2.24.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|