Re: [libvirt] [PATCH v4 0/8] Add perf and Intel CMT feature support

-----Original Message----- From: Daniel P. Berrange [mailto:berrange@redhat.com] Sent: Tuesday, March 29, 2016 8:14 PM To: Ren, Qiaowei Cc: libvir-list(a)redhat.com; Jiri Denemark Subject: Re: [PATCH v4 0/8] Add perf and Intel CMT feature support On Mon, Mar 28, 2016 at 09:30:25PM +0800, Qiaowei Ren wrote: > The series mainly adds Intel CMT feature support into libvirt. CMT is > new introduced PQos (Platform Qos) feature to monitor the usage of > cache by applications running on the platform. > > Currently CMT patches has been merged into Linux kernel mainline. > The CMT implementation in Linux kernel is based on perf mechanism and > there is no support for perf in libvirt, and so this series firstly > add perf support into libvirt, including two public API and a set of > util interfaces. And based on these APIs and interfaces, thie series > implements CMT perf event support. > > Current state: > > * 1/8 - perf: add new public APIs for perf event > - ACKed by Daniel > > * 2/8 - perf: implement the remote protocol for perf event > - ACKed by Daniel > > * 3/8 - perf: implement a set of util functions for perf event > - ACKed by Daniel > > * 4/8 - qemu_driver: add support to perf event > - restart perf in qemuProcessReconnect and qemuProcessAttach > in patch 6/8 > > * 5/8 - perf: add new xml element > - ACKed by Daniel > > * 6/8 - perf: reenable perf events when libvirtd restart > - add qemuDomainPerfRestart() into qemuProcessReconnect() and > qemuProcessAttach() > > * 7/8 - virsh: implement new command to support perf > - ACKed by Daniel > > * 8/8 - virsh: extend domstats command > - ACKed by Daniel ACK to all patches. I had some comments inline - in future just make sure you run 'make check && make syntax-check' against each patch before submitting. Since the fixes were easy I've made them myself and pushed to GIT master.