Re: [libvirt] [PATCH 4/9] qemu: Do not start with source for removable disks if tray is open
On 03/12/2012 05:10 PM, Paolo Bonzini wrote:
Il 12/03/2012 10:28, Osier Yang ha scritto:
>> VMs with physical CD-ROMs in general should not be migrated, so I think
>> migration is not a problem in this case.
>
> QEMU will prohibit that, right? if so, we have no problem here.
> Either migrate or (save + restore).
Again, it will not but it should, so for migration it's ok. When you
start the domain, we could just say tray="open" is invalid for<disk
type="block">.
We shouldn't do that while conf parsing, the only place which
might be proper is while building the qemu command line, but
I'm not quite sure if it's good to do that in libvirt, it's
more like a protection for the qemu problem. Anyway, I created
the patch, which will be posted along with the v2 series together
later, let's evaluate there then. :-)
Osier