Re: [libvirt] [PATCH] Optimization of the check for valid interface name

2 Apr 2010

On 04/02/2010 12:11 PM, Stefan Berger wrote:
...
The attached patch optimizes the validation of the name of an interface.
Signed-off-by: Stefan Berger
Index: libvirt-acl/src/conf/domain_conf.c
===================================================================

--- libvirt-acl.orig/src/conf/domain_conf.c
+++ libvirt-acl/src/conf/domain_conf.c
@@ -1795,7 +1795,7 @@ cleanup:
static bool
 isValidIfname(const char *ifname) {
-    return (strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname));
+    return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;
ACK.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

    