On Tue, Mar 24, 2015 at 05:38:37PM +0100, Peter Krempa wrote:
On Fri, Mar 20, 2015 at 15:39:04 +0100, Pavel Hrdina wrote:
We don't have to modify cpuset.mems on hosts without NUMA. It also fixes an error message that you get instead of success if you trying update vcpus of a guest on a host without NUMA.
Could you add example of the error you are fixing here?
Sure
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c4d96bd..eb86d68 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4889,7 +4889,8 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, } }
- if (flags & VIR_DOMAIN_AFFECT_LIVE && !(flags & VIR_DOMAIN_VCPU_GUEST)) { + if (flags & VIR_DOMAIN_AFFECT_LIVE && !(flags & VIR_DOMAIN_VCPU_GUEST) && + virNumaIsAvailable()) { if (virCgroupNewEmulator(priv->cgroup, false, &cgroup_temp) < 0) goto endjob;
ACK.
Peter
Thanks, will push it shortly. Pavel