Re: [libvirt] [PATCH] qemu: Reparent children when deleting a snapshot

On 23/12/2010, at 8:13 AM, Eric Blake wrote: > On 12/22/2010 01:56 PM, Matthias Bolte wrote: >> Shorten qemuDomainSnapshotWriteSnapshotMetadata function name >> and make it take a snapshot pointer instead of dealing with >> the current snapshot. Update other functions accordingly. >> >> Add a qemuDomainSnapshotReparentChildren hash iterator to >> reparent the children of a snapshot that is being deleted. Use >> qemuDomainSnapshotWriteMetadata to write updated metadata >> to disk. >> >> This fixes a problem where outdated parent information breaks >> the snapshot tree and hinders the deletion of child snapshots. >> >> Reported by Philipp Hahn. >> --- >> src/qemu/qemu_driver.c |   92 +++++++++++++++++++++++++++++++++++++----------- >> 1 files changed, 71 insertions(+), 21 deletions(-) > > ACK. Cool.  Sounds like this is the fix for BZ #663586:  https://bugzilla.redhat.com/show_bug.cgi?id=663586