Re: [libvirt] [PATCH] virsh:remove the dead code

On Thu, Dec 15, 2016 at 05:00:11AM +0800, sochin jiang wrote: > This patch remove the dead code I found. > > Signed-off-by: sochin jiang <sochin.jiang(a)huawei.com&gt; > --- > tools/virsh-domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 3a6fa5c..6dae5cc 100644 > --- a/tools/virsh-domain.c > +++ b/tools/virsh-domain.c > @@ -1005,7 +1005,6 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) > vshError(ctl, _("No support for %s in command 'attach-interface'"), > type); > goto cleanup; > - break; > } > > if (target != NULL) > @@ -7365,7 +7364,6 @@ cmdCPUCompare(vshControl *ctl, const vshCmd *cmd) > vshPrint(ctl, _("CPU described in %s is incompatible with host CPU\n"), > from); > goto cleanup; > - break; > > case VIR_CPU_COMPARE_IDENTICAL: > vshPrint(ctl, _("CPU described in %s is identical to host CPU\n"), > -- There are more occurrences of this across tools/*. Could you possibly address them all in the next version? Thanks, Erik > 1.8.3.1 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list .