Re: [libvirt] [PATCH 2/2] Add domain autostart for LXC driver
On Wed, Jul 22, 2009 at 06:52:11PM +0200, Daniel Veillard wrote:
On Wed, Jul 22, 2009 at 05:02:56PM +0100, Daniel P. Berrange wrote:
> * src/lxc_driver.c: Implement support for domain autostart
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
except that
> +static void
> +lxcAutostartConfigs(lxc_driver_t *driver) {
> + unsigned int i;
> + /* XXX: Figure out a better way todo this. The domain
> + * startup code needs a connection handle in order
> + * to lookup the bridge associated with a virtual
> + * network
> + */
> + virConnectPtr conn = virConnectOpen("lxc:///");
> + /* Ignoring NULL conn which is mostly harmless here */
which is a bit funky, I didn't spot anything, ACK
We have the same limitation in the UML and QEMU drivers - not really
got a good plan for fixing this yet...
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|