Re: [libvirt] [PATCH V9 1/3] Add a class for file descriptor sets
On 03/07/2013 11:14 AM, Stefan Berger wrote:
Implement a class for file descriptor sets. This class
remembers the mappings of aliases to file descriptor sets
and maintains the number of the next-to-use file descriptor set.
The class also writes and reads its own XML.
Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com>
---
'make syntax-check' failed:
po_check
--- ./po/POTFILES.in
+++ ./po/POTFILES.in
@@ -149,6 +149,7 @@
src/util/virerror.c
src/util/virerror.h
src/util/vireventpoll.c
+src/util/virfdset.c
src/util/virfile.c
src/util/virhash.c
src/util/virhook.c
maint.mk: you have changed the set of files with translatable diagnostics;
apply the above patch
But that fix is trivial, so I've made it locally. Depending on how the
rest of the series looks, I might just push without waiting for you to
respin a v10.
+int virFdSetParseXML(virFdSetPtr fdset, const char *xPath,
+ xmlXPathContextPtr ctxt)
+{
+
+ if (n > 0) {
+ for (i = 0 ; i < n ; i++) {
No need for the 'if' or the subsequent indentation of the for loop.
Again, trivial fix.
ACK. If I don't have any major findings on the rest of the series, then
I'll go ahead and push the corrected patch without needing to see a v10.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)