On Thu, Mar 27, 2014 at 02:57:00PM +0800, Amos Kong wrote:
This patchset fixed some issues of query-command-line-options: * some new options that haven't argument can't be queried. (eg: -enable-fips) * some legacy options that have argument can't be queried. (eg: -vnc display)
More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 https://www.redhat.com/archives/libvir-list/2014-March/msg00318.html
V2: remove duplicate option tables, update schema (eric) V3: fix typo in commitlog and export qemu_options talbe (eric) V4: avoid the duplicate static table (eric) V5: rename new field, other fix (markus) V6: add implied-name (eric, markus)
Thanks for your review!
Attached query output file, ([1] was additionally applied) [1] https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg05175.html [PATCH 0/3] ABI change: change group name of option table to match with option name ---------------------- { "name": "order", "implied-name": true, <-- optional 'implied-name' was added "type": "string" \-boot c,menu=on / -boot order=c,menu=on } ], "option": "boot" <---- "boot-opts" was fixed by [1] }, ----------------------- { "parameters": [ ], "option": "enable-fips", <-- lost enable-fips was queried \ from qemu-options.hx "unspecified-parameters": false <-- -enable-fips (bool option) }, ----------------------- { "parameters": [ <----- desc table is NULL ], "option": "cdrom", "unspecified-parameters": true <---- but it can accept argument }, ------------------------ See the detail in the attachment. Thanks, Amos
Amos Kong (3): qmp: rename query_option_descs() to get_param_info() query-command-line-options: expose implicit parameter name query-command-line-options: query all the options in qemu-options.hx