On Thu, Jul 05, 2007 at 05:24:48PM +0100, Richard W.M. Jones wrote:
Daniel Veillard wrote:
Small patch applied to qemud/libvirtd.init.in: - adds an LSB compliant header - add a couple of LSB defined functions - fixes the name in the chkconfig comments
Hopefully it's correct :-)
For reference, here are the Fedora guidelines too (they draw upon the LSB ones): http://fedoraproject.org/wiki/FCNewInit/Initscripts
Yup, +1, looks good to me.
Do those standard functions deal with the multiplicity of error codes?
well the return code of the scripts come from wrappers functions coming from init.d/functions, I assume they are correct !
When you commit this, do you think you could also add a line into qemud/.cvsignore to get it to ignore the generated file libvirtd.init
Okay,
(or else, I suppose, commit this generated file)?
Well it's not generated for me, so .cvsignore sounds better, done ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/