Re: [libvirt] PATCH 4/4: support FS template config

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > The root filesystem for an openvz guest is defined from a template name. > We support this when creating a new guest, but never include this info > when dumping the XML. Thsi patch addresses this problem by reading the > OSTEMPLATE config parameter > > diff -r e0c166ce24bd src/openvz_conf.c > --- a/src/openvz_conf.c Tue Oct 14 15:46:24 2008 +0100 > +++ b/src/openvz_conf.c Tue Oct 14 15:49:41 2008 +0100 > @@ -308,6 +308,47 @@ error: > } > > > +static int > +openvzReadFSConf(virConnectPtr conn, > + virDomainDefPtr def, > + int veid) { > + int ret; > + virDomainFSDefPtr fs; This needs to be initialized here or in the 'if' block. Otherwise, it will be freed uninitialized upon read failure: virDomainFSDefPtr fs = NULL;