Re: [libvirt] [PATCH 2/2] python: make python APIs use these helper functions
On 03/27/2012 07:11 AM, Eric Blake wrote:
On 03/26/2012 12:11 AM, Guannan Ren wrote:
> *libvirt_virDomainGetCPUStats
> *setPyVirTypedParameter
> ---
> python/libvirt-override-api.xml | 4 +-
> python/libvirt-override.c | 62 +++++---------------------------------
> 2 files changed, 11 insertions(+), 55 deletions(-)
Also, there are a lot of other places where we have the 'hacktrue' or
'hackfalse' code; we should be fixing all of those call-sites to use the
new libvirt_boolUnwrap() (although it's fine if you want to break the
cleanup into multiple commits).
libvirt_virDomainPinVcpu and libvirt_virDomainPinVcpuFlags are using
hacktrue or hackfalse to check for bool value. But there are some other
places needed to change besides only this. So I will submit patches
later
for these two APIs.
Guannan Ren