Re: [libvirt] [PATCH v2 09/10] Make qemuhotplugtest work with persistent domains
[...]
Indentation is off here.
Thank you for noticing that. Indeed, 4 spaces are missing.
+ goto cleanup;
> + break;
> + case VIR_DOMAIN_AFFECT_CONFIG:
> + if (virAsprintf(&result_filename,
> +
> "%s/qemuhotplugtestdomains/qemuhotplug-%s+%s+config.xml",
> + abs_srcdir, test->domain_filename,
> + test->device_filename) < 0)
> + goto cleanup;
> + break;
> + default:
>
No need to do default in case the switch condition is an enum, although
I'm not sure how that works with flags (non-continuous values).
You are right. It will make more sense when I change these enums to flags.
+ VIR_TEST_VERBOSE("target can either be VIR_DOMAIN_AFFECT_LIVE"
> + " or VIR_DOMAIN_AFFECT_CONFIG\n");
>
We should also take into account the fact that it can be both, but
should not be _CURRENT in tests. That way we don't have to do two lines
of DO_TEST_ATTACH_. Although that might cause confusion with the 'keep'
parameter.
I just wanted to make sure that both *_LIVE and *_CONFIG aren't supplied
at once, because handling them both isn't implemented yet.
Tomasz
Attachments:
- attachment.html (text/html — 2.7 KB)