Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands
On Tue, Jul 01, 2025 at 10:38:44 +0200, Jiri Denemark via Devel wrote:
On Mon, Jun 30, 2025 at 16:59:07 -0300, Fabiano Rosas wrote:
> The concept of capabilities is being merged into the concept of
> parameters. From now on, the commands that handle capabilities are
> deprecated in favor of the commands that handle parameters.
>
> Affected commands:
>
> - migrate-set-capabilities
> - query-migrate-capabilities
>
> Signed-off-by: Fabiano Rosas <farosas(a)suse.de>
> ---
> docs/about/deprecated.rst | 12 ++++++++++++
> migration/migration-hmp-cmds.c | 6 ++++++
> qapi/migration.json | 16 ++++++++++++++--
> 3 files changed, 32 insertions(+), 2 deletions(-)
We'll need to adapt libvirt as both commands are actively used now. Is
there a way of detecting where the relevant commands for
setting/querying parameters support capabilities? I guess QAPI schema
should work, right?
The parameters command gains the fields from "migrate-set-capabilities"
which is easy to query. Alternatively we can query the "deprecated"
feature as well.