Re: [libvirt] [PATCH v2] qemu: Fix using guest architecture as lookup key

> + /* Second attempt: use some arch-specific rules */ > + archstr = > virQEMUCapsArchToString(virQEMUCapsFindTarget(hostarch, > + > guestarch)); Nitpick, we could avoid the second search if virQEMUCapsFindTarget() returns a value that == the original guestarch.

> + if (!ret) { > + /* If the first attempt at findind capabilities has > failed, try > + * again using the QEMU target as lookup key instead */ > + data.arch = virQEMUCapsFindTarget(virArchFromHost(), > data.arch); > + ret = virHashSearch(cache->binaries, > virQEMUCapsCompareArch, &data); > + } Here too, skip the hash search if data.arch == data.arch from before.