Re: [libvirt] [PATCH] Allow building lxc without virt-login-shell

On 10.11.2015 00:28, Cédric Bosdonnat wrote: > Add a configure option to disable virt-login-shell build even if lxc is > enabled. > --- > configure.ac | 14 ++++++++++++++ > tools/Makefile.am | 12 ++++++------ > 2 files changed, 20 insertions(+), 6 deletions(-) > > diff --git a/configure.ac b/configure.ac > index f481c50..c766351 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1074,6 +1074,19 @@ if test "$with_lxc" = "yes" ; then > fi > AM_CONDITIONAL([WITH_LXC], [test "$with_lxc" = "yes"]) > > +AC_ARG_WITH([login_shell], > + [AS_HELP_STRING([--with-login-shell], > + [build virt-login-shell @<:@default=yes@:>@])]) > +m4_divert_text([DEFAULTS], [with_login_shell=yes]) > + > +if test "$with_lxc" != "yes" ; then > + with_login_shell="no" what if somebody calls ./configure --without-lxc --with-login-shell? Should we fail explicitly instead of silently disabling login shell?

> +fi > +if test "$with_login_shell" ; then > + AC_DEFINE_UNQUOTED([WITH_LOGIN_SHELL], 1, [whether virt-login-shell is built]) > +fi > +AM_CONDITIONAL([WITH_LOGIN_SHELL], [test "$with_login_shell" = "yes"]) > + Otherwise looking good. Tentative ACK. Michal