Re: [PATCH v5 00/12] nodedev state and update

On Mon, Feb 26, 2024 at 11:21:47AM +0100, Michal Prívozník wrote: > On 2/23/24 18:38, Boris Fiuczynski wrote: >> On 2/22/24 20:04, Jonathon Jongsma wrote: >>> It looks OK to me, but I'd personally like to see a second ACK on at >>> least the API-related changes. >>> >>> Reviewed-by: Jonathon Jongsma <jjongsma(a)redhat.com&gt; >> >> @Jonathon, >> thanks for your review. >> >> @all, >> I would really appreciate it if someone could take a look at the series >> before the freeze. Thanks. > > Indeed, I've marked this for review but then got sidetracked, sorry. > > Anyway, the code looks good. I just cleaned it up a bit (white spaces, > comments, curly braces) - nothing major. Appended Jonathon's Reviewed-by > where it was missing and merged (since Jirka wants to freeze right about > now). > > Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; This seems to have introduced a memory leak. See the failures reported by the Ubuntu jobs in https://gitlab.com/libvirt/libvirt/-/pipelines/1190698985 The previous pipeline was successful.