On Wed, Nov 20, 2024 at 18:48:35 +0300, Nikolai Barybin via Devel wrote:
Hello everyone!
Nikolai Barybin (15): conf: add data-file feature and related fields to virStorageSource Add VIR_STORAGE_FILE_FEATURE_DATA_FILE to virStorageFileFeature enum conf: schemas: add data-file store to domain rng schema conf: implement XML parsing/formating for dataFileStore storage file: add getDataFile function to FileTypeInfo storage file: add qcow2 data-file path parsing from header storage file: fill in src->dataFileStore during file probe security: DAC: handle qcow2 data-file on image label set/restore security: selinux: handle qcow2 data-file on image label set/restore security: apparmor: handle qcow2 data-file qemu: put data-file path to VM's cgroup and namespace qemu: factor out qemuDomainPrepareStorageSource() qemu: enable basic qcow2 data-file feature support tests: add qcow2 data-file tests docs: formatdomain: describe dataFileStore element of disk
I've finished my reviews and tests. As noted during the review I've renamed and moved the position of the XML element so that it's stored under the <source element: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/tmp/datafile.qcow2'> <dataStore type='block'> <format type='raw'/> <source dev='/dev/lvm/base1'/> </dataStore> </source> <target dev='vda' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </disk> I've fixed few bugs identified while testing the code and I'm currently running upstream CI. Once that finishes I'll push these patches with the modification I've suggested so that we avoid another round trip. Thanks! Peter