Re: [libvirt] [PATCH 1/5] write pid file into stateDir
On Fri, Dec 12, 2008 at 07:26:06PM +0100, Guido G?nther wrote:
@@ -870,6 +874,9 @@ int qemudBuildCommandLine(virConnectPtr conn,
ADD_ARG_LIT("-monitor");
ADD_ARG_LIT("pty");
+ ADD_ARG_LIT("-pidfile");
+ ADD_ARG(pidfile);
+
Not all versions of QEMU support the -pidfile argument. We'll have to add
another probe to qemudExtractVersionInfo() method as we do for -drive,
-uuid, etc.
I'm fine saying that older QEMU instances won't survive a daemon restart,
so we can just leave off -pidfile for those that don't support it.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|