Re: [libvirt] [PATCH] virsh-edit: Make force editing usable
On Thu, Feb 19, 2015 at 04:43:44PM +0100, Michal Privoznik wrote:
On 19.02.2015 15:28, Martin Kletzander wrote:
> When editing a domain with 'virsh edit' and failing validation, the
> usual message pops up:
>
> Failed. Try again? [y,n,f,?]:
>
> The option 'f' (force) is pretty unusable. It tries to step into the
> same puddle again and again when it can at least try to force the
> definition.
The idea behind force was, that imagine two virshes running. In both you
start editing the same domain. In one you successfully save the changes
and domain XML is regenerated. However, the other one notices this and
ask you, that domain definition has changed meanwhile, if you want to
continue. And by choosing 'force' you can use the force, Luke.
Yep, and in that scenario I'd still expect us todo full XML validation.
ACK though.
NACK from me
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|