On 03/21/2013 06:40 PM, Stefan Berger wrote:
On 03/21/2013 06:26 PM, Eric Blake wrote:
On 03/21/2013 04:04 PM, Stefan Berger wrote: C guarantees that this is initialized to false without having to explicitly state that.
Looks big, but it's a one-time probe done at initialization, and seems like it does the trick. You may want to wait for a review from Laine, but I didn't spot anything else wrong.
One problem:
src/nwfilter/nwfilter_ebiptables_driver.c:4346: if (inet_aton("127.0.0.1", &serveraddr.sin_addr) == 0) { maint.mk: use inet_aton_r, not inet_aton
I don't think this function exists...
Indeed not the best of messages from cfg.mk; but the explanation lies in Makefile.nonreentrant - we are explicitly rejecting inet_aton() in favor of getaddrinfo(). For that matter, src/util/virsocketaddr.c:virSocketAddrParse() might make your attempt more compact. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org