Re: [libvirt] [PATCH v2 0/4] attach-interface: Learn net type='direct'

On 02/12/2015 04:50 PM, John Ferlan wrote: > > On 02/09/2015 10:20 AM, Michal Privoznik wrote: >> v2 >> >> Michal Privoznik (4): >> libvirt_private.syms: Expose virDomainNetTypeFromString >> virsh attach-interface: Use enum instead of arbitrary integers >> virsh attach-interface: Use virDomainNetType{From,To}String() >> virsh attach-interface: Allow macvtap hotplug >> >> src/libvirt_private.syms | 1 + >> tools/virsh-domain.c | 36 ++++++++++++++++++++++++++---------- >> tools/virsh.pod | 14 ++++++++------ >> 3 files changed, 35 insertions(+), 16 deletions(-) >> > ACK series... I had thought that during V1 of this patch series there had been enough sentiment about not pulling in private parts of libvirt internals that this V2 (posted 2 minutes before the last comment in V1, so very literally crossing in the inter-tubes) would be discarded in favor of something that only used public APIs - the last word on the subject was this: https://www.redhat.com/archives/libvir-list/2015-February/msg00284.html (Yes, I know there are other places where it's already done, but it seems like a better idea to clean those up than to compound the pollution.)