13 Feb
2019
13 Feb
'19
2:31 p.m.
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote: [...]
+{"return":[{"filename":\ +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\ +"label":"charmonitor"},{"filename":"pty:/dev/pts/158",\ +"label":"charserial0"}],"id":"libvirt-3"}
Same questions as the previous patch when it comes to pretty printing: it looks like... [...]
@@ -52,10 +55,8 @@ testJSONFromFile(const void *data) if (!(actual = virJSONValueToString(injson, false))) return -1;
... changing the second argument of virJSONValueToString() to true is all that's needed to obtain much more legible output files. Any reason why we shouldn't do that? Everything else looks good. -- Andrea Bolognani / Red Hat / Virtualization