Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues
On Mon, Apr 22, 2013 at 10:43:35AM -0400, Laine Stump wrote:
On 04/22/2013 10:13 AM, Laine Stump wrote:
> Of course in this case, we *could* avoid the camelCase vs underscore
> entirely by just naming the attribute "queues" instead of numQueues or
> num_queues (the fact that the attribute is a number makes it pretty
> obvious that it is the "number of queues").
And I notice that the patches for supporting multiple queues in
interfaces uses <driver queues='n'/>, so consistency would vote in favor
of using the same thing for <controller>.
ACK, consistency is important, it could have worked by applying an
uniform rule, but we didn't, so let's try to be consistent by naming
similary for similar purpose.
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | virtualization library http://libvirt.org/