Re: [libvirt] [PATCH v5] bhyve: implement PCI address allocation
Roman Bogorodskiy wrote:
Ján Tomko wrote:
> > One more thing that bothers me: after this change user needs to
> > re-define a domain, otherwise domain will have no addresses and will
> > fail to start.
> >
> > Could/should it be handled somehow?
>
> Yes, it would be nice not to break upgrades :)
> In QEMU driver, this is done by calling AssignAddresses from QemuProcessStart.
Thanks, I'll take a look how Qemu driver does that.
PS Looks like I'm late with getting this feature into the current
release as it's unlikely I'll be able to get to it until this weekend.
I've uploaded v6 that assigns addresses in ProcessStart.
While looking at the code from Qemu I also noticed that I've missed
address assignment in CreateXML function as well.
Roman Bogorodskiy
Attachments:
- attachment.sig (application/pgp-signature — 488 bytes)