Re: [Libvir] PATCH 4/5: Change compiler flags detection

We previously added a --disable-stack-protector arg to explicitly disable the use of GCC's stack protector which is enabled when the FORTIFY_SOURCE flag is used. This is sub-optimal since the user will still get compile failures when running configure for first time, and if they're lucky will they find out about the precense of the --disable-stack-protector arg & infer what it might do. There were a couple of problems I identified - Even if giving --enable-compiler-warnings=no we would still set FORTIFY_SOURCE and related flags. - Our test for compiler flags only tried compiling, but not linking. The latter is what seemed to fail on Debian. The attached patch removes the --disable-stack-protector arg to configure, instead allowing use of --enable-compiler-warnings=no. It also makes sure to test linking with the desired flags, so that the default behaviour ought to work correctly. I'd appreciate someone with a Debian box verifying this theory... Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|